FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

removed or annotated some code which is only used in test code by firewave · Pull Request #3656 · cppcheck-opensource/cppcheck · GitHub

removed or annotated some code which is only used in test code - #3656

Merged
danmar merged 1 commit into
cppcheck-opensource:mainfrom
firewave:unusedFunction-test
Jan 3, 2022
Merged

removed or annotated some code which is only used in test code#3656
danmar merged 1 commit into
cppcheck-opensource:mainfrom
firewave:unusedFunction-test

Conversation

firewave commented Dec 25, 2021
edited
Loading

Copy link
Copy Markdown
Collaborator

These were detected by doing a unsedFunction check on the code base without including any tests.

firewave commented Dec 27, 2021
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Checked usage with git bisect:

git bisect start
git bisect bad
git checkout 3af30e728cb404a2030425ea8cb6d1845469d9b1
git bisect good
git bisect run
git bisect run grep 'normalizeCharacterLiteral(str)' lib/mathlib.cpp
git bisect reset

Last usage of duplicateDefinition in tokenize.cpp was removed in dc2a922 when simplifyEnum was removed - so it's safe to delete it.

Last usage of normalizeCharacterLiteral in mathlib.cpp was removed in f7d0bf7 - so this should be safe to remove.

firewave changed the title removed or annotated code which is only used in test code removed or annotated some code which is only used in test code Dec 27, 2021
firewave force-pushed the unusedFunction-test branch from 5fcab25 to cf6daa1 Compare December 27, 2021 10:59
firewave marked this pull request as ready for review December 27, 2021 10:59

Copy link
Copy Markdown
Collaborator Author

The build failure was a timeout in GitHub itself.

firewave commented Jan 2, 2022

Copy link
Copy Markdown
Collaborator Author

This can be merged. All other things related to this will be resolved when the CI job for this is being added.

danmar merged commit 6739995 into cppcheck-opensource:main Jan 3, 2022
firewave deleted the unusedFunction-test branch January 3, 2022 13:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL