FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix #13401 (cppcheck-addon-ctu-file-list filename should be unique for each process) by danmar · Pull Request #7082 · cppcheck-opensource/cppcheck · GitHub

/ cppcheck Public

Fix #13401 (cppcheck-addon-ctu-file-list filename should be unique for each process) - #7082

Merged
danmar merged 3 commits into
cppcheck-opensource:mainfrom
cppchecksolutions:fix-13401
Dec 8, 2024
ConversationCommits (3)ChecksFiles changed
Merged

Fix #13401 (cppcheck-addon-ctu-file-list filename should be unique for each process)#7082
danmar merged 3 commits into
cppcheck-opensource:mainfrom
cppchecksolutions:fix-13401

Conversation

danmar commented Dec 8, 2024

Copy link
Copy Markdown
Contributor

No description provided.

This was referenced Dec 8, 2024
Merged
Merged

danmar commented Dec 8, 2024

Copy link
Copy Markdown
Contributor Author

This is not tested. I am not sure how we can test it effectively and elegantly.

firewave commented Dec 8, 2024

Copy link
Copy Markdown
Collaborator

This is not tested. I am not sure how we can test it effectively and elegantly.

#6696 will do that. After all it exposed the issue.

firewave reviewed Dec 8, 2024
View reviewed changes
Comment thread lib/cppcheck.cpp Outdated
danmar and others added 2 commits December 8, 2024 18:21
executeAddons; Only create filelist if more than 1 file is processed.…
979d271 
… Processing a single ctu-info file does not require a filelist
Update lib/cppcheck.cpp
b451c08 
Co-authored-by: Oliver Stöneberg <firewave@users.noreply.github.com>

danmar commented Dec 8, 2024

Copy link
Copy Markdown
Contributor Author

#6696 will do that. After all it exposed the issue.

Thanks I agree.

firewave commented Dec 8, 2024

Copy link
Copy Markdown
Collaborator

A much cleaner solution would be to pipe that data into the process and read it from stdin. That would eliminate the usage of the temporary file and any possibility of a race condition.

danmar commented Dec 8, 2024

Copy link
Copy Markdown
Contributor Author

A much cleaner solution would be to pipe that data into the process and read it from stdin. That would eliminate the usage of the temporary file and any possibility of a race condition.

yes 👍

danmar merged commit e7a2e43 into cppcheck-opensource:main Dec 8, 2024

danmar commented Dec 8, 2024

Copy link
Copy Markdown
Contributor Author

I created ticket https://trac.cppcheck.net/ticket/13404 to update the interface.

danmar deleted the fix-13401 branch December 9, 2024 09:39
danmar added a commit that referenced this pull request Dec 10, 2024
Fix #13401 (cppcheck-addon-ctu-file-list filename should be unique fo…
8d7b56f 
…r each process) (#7082)

Co-authored-by: Oliver Stöneberg <firewave@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

firewave firewave left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL