Fix #11538: Fix syntax error on C++23 'if consteval' / 'if !consteval' - #8733
Open
autoantwort wants to merge 1 commit into
Open
Fix #11538: Fix syntax error on C++23 'if consteval' / 'if !consteval'#8733autoantwort wants to merge 1 commit into
autoantwort wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
danmar
reviewed
Jul 24, 2026
danmar
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Your suggested transformation seems valid to me. Feel free to finish this approach..
Sorry, something went wrong.
ludviggunne
reviewed
Jul 30, 2026
Comment thread
lib/tokenize.cpp
The tokenizer only recognized 'if constexpr (...)' and treated any
other 'if <name>' without parentheses as a syntax error, so C++23's
'if consteval { ... }' and 'if !consteval { ... }' were rejected.
Rewrite them to 'if ( __cppcheck_consteval__ ) { ... }' and
'if ( ! __cppcheck_consteval__ ) { ... }' respectively, using a
synthetic unresolved symbol rather than a boolean literal so that
valueflow can't treat the condition as always true/false.
autoantwort
force-pushed
the
feature/fix-if-consteval
branch
from
2ebe4cc to
e5b16e1
Compare
August 10, 2026 16:37
danmar
reviewed
Aug 19, 2026
danmar
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
you insert parentheses but the links are not set. Is that done later?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tokenizer only recognized if constexpr (...) and treated any other if <name> without parentheses as a syntax error, so C++23's if consteval { ... } and if !consteval { ... } were rejected.
Rewrite them to if ( __cppcheck_consteval__ ) { ... } and if ( ! __cppcheck_consteval__ ) { ... } respectively, using a synthetic unresolved symbol rather than a boolean literal so that valueflow can't treat the condition as always true/false.