Fix 14956: FP arrayIndexOutOfBounds with break in loop - #8772
Open
pfultz2 wants to merge 3 commits into
Open
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aadanen
reviewed
Aug 3, 2026
Comment thread
test/testbufferoverrun.cpp
| " arr[idx] = 0;\n" | ||
| "}\n"); | ||
| ASSERT_EQUALS( | ||
| "[test.cpp:9:8]: (error) Array 'arr[3]' accessed at index 3, which is out of bounds. [arrayIndexOutOfBounds]\n", |
Copy link
Copy Markdown
There was a problem hiding this comment.
Hi! I am new so sorry if this is a silly question.
I thought that if we want to return an error, we must be guaranteed that it is actually an error. In this input it looks like the array access is only out of bounds if c is true. Since we don't know anything about c, I thought we couldn't report any errors. I would expect the correct output for this testcase to be no errors.
Sorry, something went wrong.
Copy link
Copy Markdown
|
I wonder if we could catch cases like this as well: int s[5];
void f()
{
short i;
for (i = 0; 1; i++)
{
if ( i == 4 )
break;
}
s[i] = 0;
}
which currently produces break.c:10:3: error: Array 's[5]' accessed at index 9999, which is out of bounds. [arrayIndexOutOfBounds] s[i] = 0; ^ break.c:5:2: note: After for loop, i has value 9999 for (i = 0; 1; i++) ^ break.c:10:3: note: Array index out of bounds s[i] = 0; |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.