Fix #14972 [regression] Syntax Error: AST broken, '!' doesn't have an operand. - #8791
Open
chrchr-github wants to merge 1 commit into
Open
Fix #14972 [regression] Syntax Error: AST broken, '!' doesn't have an operand.#8791chrchr-github wants to merge 1 commit into
chrchr-github wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
danmar
reviewed
Aug 22, 2026
Comment thread
lib/tokenize.cpp
| Token *tok = matchMemberName(var, scopeInfo); | ||
| if (Token::Match(tok, "%name%")) { | ||
| if (!tok->next() || tok->strAt(1) != "(" || (tok->tokAt(2) && tok->tokAt(2)->isLiteral())) | ||
| if (!tok->next() || tok->strAt(1) != "(" || (tok->tokAt(2) && (tok->tokAt(2)->isLiteral() || tok->tokAt(2)->isOp()))) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
this looks fragile. Can you make sure it works with more than 1 parenthesis. I.e.:
struct Test {
static bool constant;
};
bool Test::constant((!false));
I recommend a while loop that skips ( tokens.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
Those parentheses are removed by simplifyRedundantParentheses(). Also, this change doesn't make the code more fragile than it already was.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.