AnalyzerInformation: don't store inline suppressions (Fix #14974: [regression]) - #8797
Open
autoantwort wants to merge 1 commit into
Open
AnalyzerInformation: don't store inline suppressions (Fix #14974: [regression])#8797autoantwort wants to merge 1 commit into
autoantwort wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
There is no situation where a inline suppressed error is needed again. And after loading an analysis we don't know if there were inline suppressions because we don't look at the code again. We have to keep errors that are suppressed otherwise, since command line parameters can change etc., but an inline suppression can not change without changing the file hash which invalidates the cache entry anyways.
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no situation where a inline suppressed error is needed again. And after loading an analysis we don't know if there were inline suppressions because we don't look at the code again.
We have to keep errors that are suppressed otherwise, since command line parameters can change etc., but an inline suppression can not change without changing the file hash which invalidates the cache entry anyways.