FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

selfcheck.sh: also run with system includes made available by firewave · Pull Request #438 · cppcheck-opensource/simplecpp · GitHub

selfcheck.sh: also run with system includes made available - #438

Merged
firewave merged 2 commits into
cppcheck-opensource:masterfrom
firewave:selfcheck-sys-x
Oct 2, 2025
Merged

selfcheck.sh: also run with system includes made available#438
firewave merged 2 commits into
cppcheck-opensource:masterfrom
firewave:selfcheck-sys-x

Conversation

Copy link
Copy Markdown
Collaborator

No description provided.

This comment was marked as resolved.

Copy link
Copy Markdown
Collaborator Author

This fails with

/usr/include/c++/15.1.1/ext/atomicity.h:39: syntax error: failed to evaluate #if condition, division/modulo by zero

The code in question:

#if __has_include(<sys/single_threaded.h>)
# include <sys/single_threaded.h>
#endif

firewave force-pushed the selfcheck-sys-x branch 2 times, most recently from 508ffaf to fdae274 Compare June 11, 2025 11:24
firewave force-pushed the selfcheck-sys-x branch 2 times, most recently from dd1cc3f to fbb316f Compare August 4, 2025 10:59

firewave commented Aug 4, 2025

Copy link
Copy Markdown
Collaborator Author

It now fails with

/usr/include/c++/v1/__availability:78: syntax error: failed to evaluate #if condition, undefined function-like macro invocation: __has_feature( ... )

or

/usr/include/c++/v1/__assert:29: syntax error: failed to evaluate #if condition, undefined function-like macro invocation: __has_builtin( ... )

danmar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

hmm.. my problem with this could be that maybe there will be problem in CI and no problem locally .. or no problem in CI today and then we get problems a year from now.

are the headers in a github runner fixed so they are never changed? or can they be changed at anytime (from one day to the next)?

Copy link
Copy Markdown
Collaborator Author

hmm.. my problem with this could be that maybe there will be problem in CI and no problem locally ..

Yes, that is a bit of a shortcoming. That might need some adjustment if encountered. But as we are just checking for errors and not the actual output it should be fine.

or no problem in CI today and then we get problems a year from now.

That can happen with anything in any workflow because the runners (and all other parts of the GitHub workflows) are constantly changing.

are the headers in a github runner fixed so they are never changed? or can they be changed at anytime (from one day to the next)?

No, they are not. But as mentioned above that is an issue we are constantly facing with any part of GitHub workflows.

This comment was marked as resolved.

firewave marked this pull request as draft September 11, 2025 09:51

Copy link
Copy Markdown
Collaborator Author

After integrating this with MinGW I have a few cleanups for this.

Copy link
Copy Markdown
Collaborator Author

Yes, that is a bit of a shortcoming. That might need some adjustment if encountered.

This can be improved upon later by getting the built-in include paths from the compiler (if possible).

I think I have that figured out as well.

This comment was marked as resolved.

firewave force-pushed the selfcheck-sys-x branch 4 times, most recently from 81a82d0 to 6abcbe6 Compare September 16, 2025 18:09
firewave mentioned this pull request Sep 16, 2025
Comment thread selfcheck.sh
@@ -1,11 +1,111 @@
#!/bin/sh
#!/bin/bash

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Needed so the <<< syntax works.

firewave marked this pull request as ready for review October 1, 2025 15:30
firewave merged commit a5fdea9 into cppcheck-opensource:master Oct 2, 2025
16 checks passed
firewave deleted the selfcheck-sys-x branch October 2, 2025 10:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL