test.cpp: do not unconditionally remove comments - #506
Merged
firewave merged 1 commit intoNov 7, 2025
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
firewave
force-pushed
the
test-comments
branch
from
9082c75 to
511165b
Compare
August 23, 2025 12:48
firewave
force-pushed
the
test-comments
branch
from
511165b to
6e228a1
Compare
October 28, 2025 22:04
Copy link
Copy Markdown
Collaborator
Author
|
Requires #507 to be fixed first. |
Sorry, something went wrong.
firewave
force-pushed
the
test-comments
branch
from
6e228a1 to
c962651
Compare
November 6, 2025 18:43
firewave
marked this pull request as ready for review
November 6, 2025 18:44
Copy link
Copy Markdown
Collaborator
Author
Can be fixed later on. We can just remove them explicitly for now. No need to accumulate more technical debt. |
Sorry, something went wrong.
danmar
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.