added constness_ptr as pointer wrapper to ensure actual method constness - #548
Draft
firewave wants to merge 2 commits into
Draft
added constness_ptr as pointer wrapper to ensure actual method constness#548firewave wants to merge 2 commits into
firewave wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Taken from cppcheck-opensource/cppcheck#4785. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
I might spin out the class into a separate repo (as public domain) as this seems like something useful in general. |
Sorry, something went wrong.
firewave
force-pushed
the
constness
branch
2 times, most recently
from
5909db5 to
c3ded0d
Compare
September 25, 2025 06:27
Copy link
Copy Markdown
Collaborator
Author
|
This fails to compile with GCC before 15: simplecpp.cpp:1742:37: error: operands to ‘?:’ have different types ‘const simplecpp::constness_ptr<simplecpp::Token>’ and ‘std::nullptr_t’
1742 | valueToken = argtok ? argtok->next : nullptr;
| ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
And with Visual Studio: 6>C:\a\simplecpp\simplecpp\simplecpp.cpp(1742,54): error C2446: ':': no conversion from 'nullptr' to 'const simplecpp::constness_ptr<simplecpp::Token>' [C:\a\simplecpp\simplecpp\simplecpp_obj.vcxproj]
C:\a\simplecpp\simplecpp\simplecpp.cpp(1742,54):
Constructor for class 'simplecpp::constness_ptr<simplecpp::Token>' is declared 'explicit'
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
We do not actually need to actually implement the class. As this is a compile-time check it would be enough to have a simple wrapper which does nothing and having a compile-time switch which makes it an alias for std::experimental::propagate_const. |
Sorry, something went wrong.
firewave
force-pushed
the
constness
branch
2 times, most recently
from
02f2e36 to
faaf570
Compare
June 3, 2026 09:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.