fixed #632 - avoid unhandled simplecpp::Macro::Error in simplecpp::preprocess with -D - #631
Conversation
Sorry, something went wrong.
| simplecpp::Output err{ | ||
| simplecpp::Output out{ | ||
| Output::SYNTAX_ERROR, | ||
| rawtok->location, |
There was a problem hiding this comment.
this will not read the location from the exception. are you 100% sure that exception provides the rawtok location?
Sorry, something went wrong.
There was a problem hiding this comment.
Good point. The location in the existing test did not change so I missed that. The issue is that the tests do not provide a filename. I will improve the tests.
Sorry, something went wrong.
There was a problem hiding this comment.
I wonder if the location here is actually correct since a std::runtime_error can already be thrown from several places. We should possibly throw a custom class.
I will adjust this PR to add the additional exception handling to address the issue and extract all the further changes into a separate PR.
Sorry, something went wrong.
There was a problem hiding this comment.
Done.
Sorry, something went wrong.
…ror` in `simplecpp::preprocess` with `-D`
No description provided.