use std::vector as underlying container for std::stack in simplecpp::TokenList::readfile() - #660
Closed
firewave wants to merge 1 commit into
Closed
use std::vector as underlying container for std::stack in simplecpp::TokenList::readfile()#660firewave wants to merge 1 commit into
firewave wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…cpp::TokenList::readfile()`
Copy link
Copy Markdown
Collaborator
Author
|
Running ./testrunner in valgrind: GCC 16 - 73,545,066 -> 72,183,597 |
Sorry, something went wrong.
firewave
marked this pull request as draft
June 11, 2026 05:22
Copy link
Copy Markdown
Collaborator
Author
|
There is a slight increase with callgrind in the CI which needs looking into first. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Closing as the code in question will be removed by #585. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.