FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix #680: Add option to keep comments in preprocessed code by ludviggunne · Pull Request #681 · cppcheck-opensource/simplecpp · GitHub

/ simplecpp Public

Fix #680: Add option to keep comments in preprocessed code - #681

Merged
ludviggunne merged 3 commits into
cppcheck-opensource:masterfrom
ludviggunne:keep-comments
Jul 24, 2026
ConversationCommits (3)ChecksFiles changed
Merged

Fix #680: Add option to keep comments in preprocessed code#681
ludviggunne merged 3 commits into
cppcheck-opensource:masterfrom
ludviggunne:keep-comments

Conversation

ludviggunne commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

danmar reviewed Jul 13, 2026
View reviewed changes

danmar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't see the use case to treat comments differently in the source file and in included files. do you know the reason?

danmar commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

The removeComments was added in #340 and it seems that it was added for performance reasons only, there is no known use case as far as I see when we want to only remove the comments in the included files.

So I suggest that we just keep the removeComments flag. If that is false then keep all comments. If that is true the remove all comments.

The performance optimisation might be less interesting after Tommys recent fix also so that files are not redundantly loaded.

danmar approved these changes Jul 13, 2026
View reviewed changes
Comment thread test.cpp

{
const char code[] = "#define MACRO /* comment */\nMACRO\n";
ASSERT_EQUALS("\n/* comment */", preprocess(code,dui));

danmar Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this may be questionable. do we want that comments are expanded. maybe the comment should only be kept on line 1.

but for now .. as far as I see it does not matter much. If somebody has strong opinions later and wants to change I am not against changing..

ludviggunne Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

gcc does copy comments in expansions. it will however turn c++-style comments in to c-style comments: https://gcc.gnu.org/onlinedocs/gcc/Preprocessor-Options.html

ludviggunne merged commit 1537e9e into cppcheck-opensource:master Jul 24, 2026
25 checks passed
ludviggunne deleted the keep-comments branch July 24, 2026 13:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

danmar danmar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL