Use standard fixed-width typenames for cast checks - #282
Merged
aaronliu0130 merged 6 commits intoAug 24, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Use uint16_t,int32_t,etc instead of uint16,int32,etc as the expected typenames when looking for c-style casts.
aaronliu0130
requested changes
Aug 15, 2024
aaronliu0130
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Good catch! The client testcases need to be updated. This should be trivial, and if not, I'll attempt that tomorrow.
Sorry, something went wrong.
Comment thread
samples/silly-sample/src/sillycode.cpp
Outdated
aaronliu0130
approved these changes
Aug 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use uint16_t,int32_t,etc instead of uint16,int32,etc as the expected typenames when looking for c-style casts.