Remove readability/fn_size error throw - #287
Merged
aaronliu0130 merged 1 commit intoSep 7, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
I agree that fn_size should be disabled, as the style guide says "no hard limit is placed on function length." But I think you can just add -readability/fn_size to _DEFAULT_FILTERS. No need to remove anything. |
Sorry, something went wrong.
aduh95
force-pushed
the
fix-readability/fn_size
branch
from
34a534a to
73f2546
Compare
September 6, 2024 23:07
Copy link
Copy Markdown
Contributor
Author
|
@matyalatte you're right, that's a much better and simpler fix 👍 |
Sorry, something went wrong.
aaronliu0130
approved these changes
Sep 7, 2024
aaronliu0130
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I guess those interested could manually reenable it.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @RafaelGSS
Refs: nodejs/node#54744