GitHub Actions: pipx run pre-commit run --all-files - #324
Merged
cclauss merged 2 commits intoMar 6, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
aaronliu0130
approved these changes
Mar 6, 2025
aaronliu0130
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM if/when the checks complete. BTW I wonder if we should add pre-commit to dev-requirements?
Sorry, something went wrong.
Merged
Copy link
Copy Markdown
Member
Author
|
Let's not add pre-commit to dev requirements. It is optional. If contributors do not install it GitHub Actions will still catch the problems. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.