FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Ruff rules PL for Pylint by cclauss · Pull Request #330 · cpplint/cpplint · GitHub

/ cpplint Public

Ruff rules PL for Pylint - #330

Merged
cclauss merged 1 commit into
developfrom
ruff-rules-PL-for-pylint
Mar 11, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Ruff rules PL for Pylint#330
cclauss merged 1 commit into
developfrom
ruff-rules-PL-for-pylint

Conversation

cclauss commented Mar 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Add ruff rules PL for Pylint: https://docs.astral.sh/ruff/rules/#pylint-pl
% ruff check --select=PL
% ruff check --select=PLR0 --preview

cclauss commented Mar 7, 2025
View reviewed changes
Comment thread cpplint.py Outdated

cclauss Mar 7, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should the second item be --v or just -v?

jayvdb Mar 8, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

How about we include both?

Or we should check whether --v can be removed, as that is non-standard and hopefully not in use

aaronliu0130 Mar 8, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'd prefer replacing --v, but I have no idea how we'll check if people use --v.

cclauss Mar 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Discussion moved because this would be a breaking change as in that current production usage may break.

cclauss mentioned this pull request Mar 8, 2025
Open
cclauss requested review from aaronliu0130 and jayvdb March 8, 2025 06:39
cclauss force-pushed the ruff-rules-PL-for-pylint branch from 0f82b45 to 01e6e78 Compare March 8, 2025 12:44
cclauss force-pushed the ruff-rules-PL-for-pylint branch from 01e6e78 to dac8fda Compare March 11, 2025 18:30

cclauss commented Mar 11, 2025

Copy link
Copy Markdown
Member Author

Reviews please.

cclauss merged commit 66c4c80 into develop Mar 11, 2025
cclauss deleted the ruff-rules-PL-for-pylint branch March 11, 2025 22:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aaronliu0130 aaronliu0130 approved these changes
jayvdb Awaiting requested review from jayvdb

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL