Conversation
Sorry, something went wrong.
v2.0.1 published...https://github.com/cpplint/cpplint/releases |
Sorry, something went wrong.
| paths-ignore: "*.rst" | ||
| push: | ||
| paths-ignore: "*.rst" | ||
| # paths-ignore: "*.rst" |
There was a problem hiding this comment.
why lol *.rst changes cannot break code/tests and pre-commit errors are in a separate workflow anyway.
Sorry, something went wrong.
There was a problem hiding this comment.
There are three required GitHub Actions tests before a pull request is merged. Without this change, a pull request that only changes .rst files can never be merged. Failing to plan is planing to fail.
Sorry, something went wrong.
There was a problem hiding this comment.
Good point. Your change does not do anything to stop that, though, as all you changed is the part applying to pushes to the master and develop branches. I'm currently asking https://github.com/orgs/community/discussions/155654 to implement an alternative measure of path-filtering (removing the ignorance from both is also an option but I don't think we need it enough for a separate commit; I won't oppose such a change though).
Sorry, something went wrong.
Bump the date again before releasing 2.0.1, then squash and merge and release (remember to create a new tag and follow the testing process in CONTRIBUTING.rst).