FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Drop flake8 in favor of ruff by cclauss · Pull Request #356 · cpplint/cpplint · GitHub

/ cpplint Public

Drop flake8 in favor of ruff - #356

Merged
cclauss merged 2 commits into
developfrom
drop-flake8
Apr 1, 2025
ConversationCommits (2)ChecksFiles changed
Merged

Drop flake8 in favor of ruff#356
cclauss merged 2 commits into
developfrom
drop-flake8

Conversation

cclauss commented Apr 1, 2025

Copy link
Copy Markdown
Member

No description provided.

cclauss requested a review from Copilot April 1, 2025 16:56
Copilot AI reviewed Apr 1, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull Request Overview

This PR migrates the linting configuration by dropping flake8 in favor of ruff, while also updating version numbers for both ruff and the pyproject validator.

  • Updated ruff version from v0.11.0 to v0.11.2
  • Removed the flake8 repository configuration
  • Updated the validate-pyproject revision from v0.24 to v0.24.1
Files not reviewed (1)
  • .flake8: Language not supported

aaronliu0130 approved these changes Apr 1, 2025
View reviewed changes

aaronliu0130 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

All the rules indeed seem to be implemented in ruff to me! Another thing you might consider doing is a monthly (ish?) pre-commit autoupdate scheduled CI job.

cclauss merged commit b66973c into develop Apr 1, 2025
cclauss deleted the drop-flake8 branch April 1, 2025 18:59

cclauss commented Apr 1, 2025

Copy link
Copy Markdown
Member Author

you might consider doing is a monthly (ish?) pre-commit autoupdate scheduled CI job.

Done at https://results.pre-commit.ci/repo/github/47154941

aaronliu0130 commented Apr 1, 2025

Copy link
Copy Markdown
Member

Correct me if I'm wrong, but isn't that just running pre-commit on the entire repository instead of bumping the versions of the pre-commit hooks?

cclauss commented Apr 1, 2025

Copy link
Copy Markdown
Member Author

https://pre-commit.ci says...

automatic updates: pre-commit.ci will periodically autoupdate your configuration ensuring that your hook versions are kept up to date. this autoupdate is currently scheduled weekly at approximately 16:00 UTC Monday.

aaronliu0130 commented Apr 1, 2025

Copy link
Copy Markdown
Member

Makes sense! I'm struggling to find a run yesterday that checked for updates though, but I'll take their word for it.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
aaronliu0130 aaronliu0130 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL