Duplicate — see my other review on this PR.

Reviewed at bce7f59 against current develop.

Fixes the #385 case and the harder valid C++20 forms that a same-line ]<...> check misses — multiline template parameter lists, ]<T> with ( on the next line, and trailing requires-clauses. I compiled those with g++ -std=c++20 -pedantic-errors -fsyntax-only and confirmed they stay clean here while ordinary templated/constrained functions and operator[] (including multiline) still warn. Full unit suite: 206 passed.

This conflicts with #458; I’d take this one — it’s the more complete coverage for the same issue.

cpplint_unittest.py (1)

3169-3201: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add coverage for a trailing lambda requires clause.

The new tests only cover a requires clause before the lambda parameter list. C++20 also permits a clause after the parameter list. A matcher regression in that form will pass this suite.

Proposed test

+        self.TestMultiLineLint(
+            "auto identity = []<typename T>(T&& t)\n"
+            "    requires std::integral<T> &&\n"
+            "             std::copyable<T>\n"
+            "{\n"
+            "  return t;\n"
+            "};\n",
+            "",
+        )

Verify this form with the project C++20 compiler.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@cpplint_unittest.py` around lines 3169 - 3201, Add a TestMultiLineLint case
alongside the existing generic lambda requires-clause cases covering a trailing
requires clause after the lambda parameter list, including a multiline
constraint if appropriate. Use valid C++20 syntax and verify the test with the
project’s C++20 compiler, expecting no lint errors.

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@cpplint_unittest.py`:
- Around line 5787-5793: Update the assertion in the multiple-same-basename test
to count the diagnostic associated with foo.cc rather than bar_header_error,
while preserving the expectation that including foo.hpp produces no
related-header error for foo.cc. Use the existing diagnostic symbol or
construction for foo.cc from the surrounding test setup.

---

Nitpick comments:
In `@cpplint_unittest.py`:
- Around line 3169-3201: Add a TestMultiLineLint case alongside the existing
generic lambda requires-clause cases covering a trailing requires clause after
the lambda parameter list, including a multiline constraint if appropriate. Use
valid C++20 syntax and verify the test with the project’s C++20 compiler,
expecting no lint errors.

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6381b6bc-67e3-421c-ac55-69ec440f368d

Reviewing files that changed from the base of the PR and between bce7f59 and fee646d.

• CHANGELOG.rst
• cpplint.py
• cpplint_unittest.py

• CHANGELOG.rst
• cpplint.py

Rechecked at fee646d. Merge with current develop looks clean — both changelog entries are preserved, and the templated-lambda logic is unchanged from bcf7f59.

Re-ran the earlier cases against this head: #385, multiline template params, ]<T>n(, and requires-clauses stay clean; templated/constrained functions and multiline operator[] still warn. Full suite: 206 passed. Still LGTM.

Reviewed at fee646d.

The matcher keeps ordinary constrained functions and multiline operator[] declarations in the trailing-semicolon path while recognizing the C++20 templated-lambda forms. I also checked a trailing requires-clause lambda and confirmed it stays clean under the repository's brace-style rule.

Verified locally:

python -m pytest --no-cov -q
231 passed

git diff --check upstream/develop...HEAD
Passed

LGTM.