#696: replace huge Java fixtures with inline examples - #1372
Open
AzazelSensei wants to merge 1 commit into
Open
AzazelSensei wants to merge 1 commit into
AzazelSensei wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
The slow pattern tests were parsing 100KB+ copies of Hadoop and Lottie sources. I inlined the same cases as tiny Java strings and dropped those fixtures for er_class, implements_multi, and send_null.
Copy link
Copy Markdown
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 1b7e2af2-7162-4b29-a723-c56701c05e24 📥 CommitsReviewing files that changed from the base of the PR and between 8a77edb and 277290c. 📒 Files selected for processing (35)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 Walkthrough WalkthroughThe pattern tests were migrated from Java fixture files and unittest classes to inline Java snippets and standalone pytest functions. Obsolete Java fixture files were deleted, including the FillContent fixture. ChangesPattern test migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to 27729 The PR replaces large test fixtures with equivalent inline examples and removes unused files without changing production behavior. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The slow tests in #696 were parsing 100KB+ Java copies just to hit a handful of lines.
I replaced those fixtures with inline snippets for er_class, implements_multi, and send_null, and deleted the unused files. The same cases still fail the patterns; they just do not pay for a full Hadoop Configuration parse.
pytest test/patterns/er_class test/patterns/implements_multi test/patterns/send_null — 45 passed, slowest ~10ms.
Summary by CodeRabbit
Tests
Refactor
User Impact