FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[6.x] Replace suggestion comboboxes with text expanders by riasvdv · Pull Request #19457 · craftcms/cms · GitHub

/ cms Public

[6.x] Replace suggestion comboboxes with text expanders - #19457

Merged
brandonkelly merged 9 commits into
6.xfrom
feature/review-combobox-suggestions
Aug 20, 2026
Merged

[6.x] Replace suggestion comboboxes with text expanders#19457
brandonkelly merged 9 commits into
6.xfrom
feature/review-combobox-suggestions

Conversation

riasvdv commented Aug 19, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Replaces environment variable and alias suggestion comboboxes with text inputs using text expanders, and adds object-template suggestions to template-aware fields.

  • Environment variable suggestions ($) were added to:
    • System Name
    • Installer Site Base URL
    • Site Group Name, Site Name, and Site Base URL
    • Default and per-site System Email Address, Sender Name, and Reply-To Address
    • Local filesystem Base URL and Base Path
    • Asset volume Subpath and Transform Subpath
    • Section Preview Target URL Format
    • Element-select condition ID inputs
  • Alias suggestions (@) are supported by URL/path fields that accept aliases:
    • Installer and Site Base URL
    • Local filesystem Base URL and Base Path
    • Section Preview Target URL Format
  • Object-template suggestions ({) were added to:
    • Generated Fields table Template
    • Entry type UI Label Format, Default Title Format, Title Translation Key Format, and Slug Translation Key Format
    • Section Preview Target URL Format and Entry URI Format
    • Custom field Translation Key Format
    • Matrix Propagation Key Format and nested Entry URI Format
    • Asset field Restricted Location Subpath, Restricted Default Upload Subpath, and Default Upload Location Subpath
    • Asset volume Title Translation Key Format and Alt Translation Key Format
    • User Photo Subpath
  • Object-template suggestions include common element properties, type-specific Address, Asset, Entry, and User properties, and custom fields from applicable field layouts. Nested Content Block fields are included recursively.
  • Text expander changes:
    • Changed trigger configuration to an ordered array, allowing repeated triggers with start, whitespace, or anywhere boundaries.
    • Uses the same $ trigger for environment variables, inserting $NAME at the start and ${NAME} when embedded in text.
    • Added default rendering for option hints from data.hint.
    • Allows dots in active queries for nested object properties.
    • Preserves the open popup and active option across reactive form refreshes.
    • Shows all returned suggestions by default, keeps explicit per-trigger limits, and scrolls the listbox within a 320px maximum height.
  • Added text-expander support to the PHP Input component, generated Vue CraftInput wrapper, and editable-table text/template cells.
  • Added shared environment and object-template trigger builders and hint text in SelectOptions.
  • Removed the unused SiteOverridesTable.vue component and updated related tests, stories, fixtures, and the changelog.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Replaces environment/alias comboboxes with text expanders and adds typed object-template suggestions across control-panel forms.

Changes:

  • Adds boundary-aware, dotted-property text-expander support.
  • Generates environment, alias, element, and custom-field suggestions.
  • Integrates expanders into PHP, Vue, and editable-table forms with tests.

Reviewed changes

Copilot reviewed 52 out of 52 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
workbench/app/Forms/FormKitchenSink.php Updates trigger fixtures.
tests/Unit/Form/CompositeControlsTest.php Updates trigger assertions.
tests/Unit/Cp/FormFieldsTest.php Tests legacy field mapping.
tests/Unit/Cp/Components/InputTest.php Tests input expander rendering.
tests/Feature/Cp/SelectOptionsTest.php Tests generated suggestions.
tests/Feature/Condition/ConditionBuilderHtmlTest.php Tests condition-rule integration.
src/View/Contracts/ProvidesObjectTemplateSuggestions.php Defines suggestion-provider contract.
src/User/Elements/User.php Adds user properties.
src/Http/ViewModels/UserSettingsViewModel.php Adds user-path suggestions.
src/Http/ViewModels/SectionEditViewModel.php Adds section template suggestions.
src/Http/ViewModels/FieldEditViewModel.php Adds translation-key suggestions.
src/Http/ViewModels/EntryTypeEditViewModel.php Adds entry-format suggestions.
src/Http/Controllers/Settings/VolumesController.php Supplies volume triggers.
src/Http/Controllers/Settings/SitesController.php Replaces site comboboxes.
src/Http/Controllers/Settings/GeneralSettingsController.php Replaces system-name combobox.
src/Http/Controllers/Settings/EmailSettingsController.php Replaces email comboboxes.
src/Http/Controllers/InstallController.php Supplies installer triggers.
src/Form/Controls/Concerns/HasTextExpander.php Revises trigger schema.
src/Filesystem/Filesystems/Local.php Adds filesystem expanders.
src/FieldLayout/FieldLayout.php Resolves nested field suggestions.
src/Field/Matrix.php Adds Matrix template suggestions.
src/Field/Assets.php Adds asset-path suggestions.
src/Entry/Elements/Entry.php Adds entry properties.
src/Element/Element.php Adds base element properties.
src/Element/Contracts/ElementInterface.php Extends suggestion contract.
src/Cp/SelectOptions.php Generates expander triggers.
src/Cp/FormFields.php Maps legacy trigger config.
src/Cp/FieldLayoutDesigner/FieldLayoutDesigner.php Configures template-column suggestions.
src/Cp/Components/Input.php Renders input expanders.
src/Condition/BaseElementSelectConditionRule.php Replaces condition autosuggest.
src/Asset/Elements/Asset.php Adds asset properties.
src/Address/Elements/Address.php Adds address properties.
resources/templates/settings/assets/volumes/_edit.twig Migrates volume fields.
resources/js/pages/settings/sites/Index.vue Migrates group-name input.
resources/js/modules/settings/components/email/SiteOverridesTable.vue Removes obsolete table.
resources/js/modules/markdown-field/markdown-field.test.ts Updates trigger fixture.
resources/js/modules/install/components/SiteFields.vue Migrates installer URL input.
resources/js/modules/forms/TextControl.test.ts Updates trigger fixture.
resources/js/modules/forms/TextareaControl.test.ts Updates trigger fixture.
resources/js/modules/forms/TableControl.vue Reads native table inputs.
resources/js/modules/forms/FormRenderer.test.ts Tests refresh preservation.
resources/js/modules/editable-table/types.ts Types table triggers.
resources/js/modules/editable-table/editable-table.ts Renders table expanders.
resources/js/modules/editable-table/editable-table.test.ts Tests table expanders.
resources/js/common/form/CraftInput.test.ts Tests Vue input integration.
packages/craftcms-ui/src/index.ts Exports boundary type.
packages/craftcms-ui/src/components/text-expander/text-expander.ts Adds boundaries and preservation.
packages/craftcms-ui/src/components/text-expander/text-expander.test.ts Tests new behavior.
packages/craftcms-ui/src/components/text-expander/text-expander.stories.ts Updates component stories.
packages/craftcms-ui/scripts/generate-vue-wrappers.js Generates input wrapper support.
CHANGELOG.md Documents the improvement.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

github-actions Bot commented Aug 19, 2026
edited
Loading

Copy link
Copy Markdown

📚 Storybook previews

@craftcms/uiopen Storybook

Changed components:

resources/jsopen Storybook

No changed components detected in this Storybook.

riasvdv marked this pull request as ready for review August 19, 2026 10:23

linear-code Bot commented Aug 19, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

CMS-2358

CMS-2359

brandonkelly merged commit 504f226 into 6.x Aug 20, 2026
23 checks passed
brandonkelly deleted the feature/review-combobox-suggestions branch August 20, 2026 17:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL