[DRAFT] Add Node.js feature - #67
Draft
Taliik wants to merge 11 commits into
Draft
Taliik wants to merge 11 commits into
Taliik wants to merge 11 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…wait a short period of time.
amotl
reviewed
Dec 6, 2022
amotl
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Hi @Taliik,
it looks like @lukasbals added a showcase implementation for Node.js at 1 already. I did not scan both implementations too closely, maybe your variant includes important details not addressed by the other one from @lukasbals?
Otherwise, let's close this PR?
With kind regards,
Andreas.
Footnotes
Sorry, something went wrong.
Comment thread
node-js/package.json
| "license": "Apache-2.0", | ||
| "dependencies": { | ||
| "express": "^4.15.3", | ||
| "node-crate": "^2.0.1", |
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Contrary to my previous assessment, it looks like node-crate is well alive and maintained 1.
Footnotes
Sorry, something went wrong.
amotl
marked this pull request as draft
January 11, 2023 13:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.