Remove forward declarations to cgo exported funcs - #146
Open
iamcalledrob wants to merge 3 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Feel free to submit over at https://github.com/go-llsqlite/crawshaw if you get no traction. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
@anacrolix I submitted a PR in that repo already! go-llsqlite/crawshaw#5 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current source fails to build with clang on windows due to forward declarations.
It appears that cgo code within a go file shouldn't contain a forward declaration to a cgo exported function from within the same file.
This manifests as either a warning or an error on clang+windows due to dllexport. There is an open task on the golang repo to better document this: golang/go#49721
Here's what happens if you try and build this package using clang (or zig cc) on windows.
In file included from _cgo_export.c:4: cgo-gcc-export-header-prolog:49:34: error: redeclaration of 'go_sqlite_auth_tramp' cannot add 'dllexport' attribute 49 | extern __declspec(dllexport) int go_sqlite_auth_tramp(GoUintptr id, int action, char* cArg1, char* cArg2, char* cDB, char* cTrigger); | ^ auth.go:5:13: note: previous declaration is here 5 | extern int go_sqlite_auth_tramp(uintptr_t, int, char*, char*, char*, char*); | ^ cgo-gcc-export-header-prolog:50:35: warning: redeclaration of 'func_tramp' should not add 'dllexport' attribute [-Wdll-attribute-on-redeclaration] 50 | extern __declspec(dllexport) void func_tramp(sqlite3_context* ctx, int n, sqlite3_value** valarray); | ^ func.go:22:14: note: previous declaration is here 22 | extern void func_tramp(sqlite3_context*, int, sqlite3_value**); | ^ cgo-gcc-export-header-prolog:51:35: warning: redeclaration of 'step_tramp' should not add 'dllexport' attribute [-Wdll-attribute-on-redeclaration] 51 | extern __declspec(dllexport) void step_tramp(sqlite3_context* ctx, int n, sqlite3_value** valarray); | ^ func.go:23:14: note: previous declaration is here 23 | extern void step_tramp(sqlite3_context*, int, sqlite3_value**); | ^ cgo-gcc-export-header-prolog:52:35: warning: redeclaration of 'final_tramp' should not add 'dllexport' attribute [-Wdll-attribute-on-redeclaration] 52 | extern __declspec(dllexport) void final_tramp(sqlite3_context* ctx); | ^ func.go:24:14: note: previous declaration is here 24 | extern void final_tramp(sqlite3_context*); | ^ cgo-gcc-export-header-prolog:54:34: warning: redeclaration of 'go_strm_w_tramp' should not add 'dllexport' attribute [-Wdll-attribute-on-redeclaration] 54 | extern __declspec(dllexport) int go_strm_w_tramp(GoUintptr pOut, char* pData, int n); | ^ session.go:22:13: note: previous declaration is here 22 | extern int go_strm_w_tramp(uintptr_t, char*, int); | ^ cgo-gcc-export-header-prolog:55:34: warning: redeclaration of 'go_strm_r_tramp' should not add 'dllexport' attribute [-Wdll-attribute-on-redeclaration] 55 | extern __declspec(dllexport) int go_strm_r_tramp(GoUintptr pIn, char* pData, int* pnData); | ^ session.go:23:13: note: previous declaration is here 23 | extern int go_strm_r_tramp(uintptr_t, char*, int*); | ^ cgo-gcc-export-header-prolog:58:35: error: redeclaration of 'log_fn' cannot add 'dllexport' attribute 58 | extern __declspec(dllexport) void log_fn(void* _, int code, char* msg); | ^ sqlite.go:55:14: note: previous declaration is here 55 | extern void log_fn(void* pArg, int code, char* msg); | ^ 5 warnings and 2 errors generated.This PR:
Should fix the root issue in #137