FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added additional error handling on being unable to access github by 0xicingdeath · Pull Request #80 · crytic/solc-select · GitHub

/ solc-select Public

Added additional error handling on being unable to access github - #80

Draft
0xicingdeath wants to merge 1 commit into
devfrom
fix/halt-if-cannot-access
ConversationCommits (1)ChecksFiles changed
Draft

Added additional error handling on being unable to access github#80
0xicingdeath wants to merge 1 commit into
devfrom
fix/halt-if-cannot-access

Conversation

0xicingdeath commented Dec 1, 2021 •
edited
Loading

Copy link
Copy Markdown

Scenarios:

  1. If GitHub is unreachable, the earliest_release should be 0.4.10 instead of 0.4.0.
  2. If soliditylang is unreachable, an error should be raised
  3. If a user installs all, then all binaries from soliditylang will be installed, with a warning message that 0.4.0-0.4.9 are unavailable
  4. If a user tries to fetch available versions and GitHub is unreachable, solc-select will continue execution, with a warning message that 0.4.0-0.4.9 are unavailable

Setting this to a draft PR, so we have time to think about how to test.

0xicingdeath marked this pull request as draft December 1, 2021 19:15

antonper commented Nov 1, 2022

Copy link
Copy Markdown

In current version also valid_version always tries to query latestRelease. It would be nice if in case github is not accessible the latest version check will not fail.

CLAassistant commented Jun 24, 2024

Copy link
Copy Markdown


Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Natalie Chin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

elopez Awaiting requested review from elopez elopez will be requested when the pull request is marked ready for review elopez is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL