feat: remove extra space before media dn suppots at-rules - #640
Open
alexander-akait wants to merge 1 commit into
Open
alexander-akait wants to merge 1 commit into
alexander-akait wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Tests look fine. Have we tested so that this change actually works as expected in different browsers? Perhaps we could throw something up on codepen and execute it with browserstack? PS. Don't forget to update integration tests. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@andyjansson maybe, will be great have simple tests for browserstack. Anyway other minifications for css remove this space and looks in their bug tracker no issue related to this. |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #324
Also: