Strip ArcGIS metadata sidecars from the shapefile fixtures - #62
Merged
njakobsen merged 1 commit intoAug 16, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Ten fixture archives carried the `.shp.xml` sidecar that ArcGIS writes beside an export. It describes the workstation that produced the file rather than the shapefile itself, which is not something a fixture in a public repository needs to carry. Nothing reads these files. The importer selects archive members by a `.shp` extension anchored at the end of the name, so a `.shp.xml` sibling has never matched, and no spec refers to one. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ten of the shapefile fixture archives carried the .shp.xml sidecar that ArcGIS writes alongside an export. That file describes the workstation and toolchain that produced the shapefile rather than the shapefile itself, and it is not something a fixture in a public repository needs to carry.
Nothing reads them. Unzip.paths selects archive members with a .shp extension anchored at the end of the name, so a .shp.xml sibling has never matched, and no spec refers to one. The .shp, .dbf, .shx and .prj components are untouched, so every fixture still exercises exactly what it did before.
Full suite is green locally: 266 examples, 0 failures.
🤖 Generated with Claude Code
https://claude.ai/code/session_017uHh49RG66T3qNFNRnPY6s