FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

CM-67318: Warn when env vars override configured credentials by ilia-cy · Pull Request #474 · cycodehq/cycode-cli · GitHub

/ cycode-cli Public

CM-67318: Warn when env vars override configured credentials - #474

Merged
ilia-cy merged 1 commit into
mainfrom
CM-67318-warn-env-var-override-in-configure
Jun 21, 2026
ConversationCommits (1)ChecksFiles changed
Merged

CM-67318: Warn when env vars override configured credentials#474
ilia-cy merged 1 commit into
mainfrom
CM-67318-warn-env-var-override-in-configure

Conversation

ilia-cy commented Jun 21, 2026 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

  • cycode configure writes credentials to ~/.cycode/credentials.yaml, but CYCODE_CLIENT_ID/CYCODE_CLIENT_SECRET (and the API/APP URL env vars) take precedence on every subsequent call. The override notice was previously only appended to the success message when a value actually changed, so a stale env var could silently shadow freshly configured credentials with no warning.
  • Split the env-var override notice out of the success messages into dedicated helpers (get_credentials_environment_variables_override_warning / get_urls_environment_variables_override_warning).
  • configure now prints these as Warning: lines whenever the relevant env vars are set — regardless of whether anything was updated (also covers the partial case where only the client id is set).
  • Env-over-file precedence is intentional (CI/CD), so it is unchanged; this only adds the missing warning.
  • Added tests/cli/commands/configure/test_messages.py covering the new helpers.

Jira

CM-67318

🤖 Generated with Claude Code

CM-67318: warn when env vars override configured credentials/URLs
9ced2ad 
cycode configure writes credentials to the file but CYCODE_CLIENT_ID/
CYCODE_CLIENT_SECRET (and the URL env vars) take precedence on every
subsequent call. Previously the override notice was only appended to the
success message when a value actually changed, so a stale env var could
silently shadow freshly configured credentials with no indication.

Split the override notice into its own helpers and print it as a warning
whenever the relevant env vars are set, regardless of whether anything
was updated.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ilia-cy self-assigned this Jun 21, 2026
ilia-cy merged commit d7f4076 into main Jun 21, 2026
28 checks passed
ilia-cy deleted the CM-67318-warn-env-var-override-in-configure branch June 21, 2026 12:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

omer-roth omer-roth approved these changes
avishaiamiel Awaiting requested review from avishaiamiel avishaiamiel is a code owner

Assignees

ilia-cy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL