FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixes issue #380[Windows] Crash on exit with multi_threaded_message_l… by Jack-2025 · Pull Request #412 · cztomczak/cefpython · GitHub

Repository navigation

Fixes issue #380[Windows] Crash on exit with multi_threaded_message_l… - #412

Closed
Jack-2025 wants to merge 2 commits into
cztomczak:masterfrom
Jack-2025:master
Closed

Jack-2025 wants to merge 2 commits into
cztomczak:masterfrom
Jack-2025:master

Conversation

Copy link
Copy Markdown
Contributor

No description provided.

cztomczak left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thew new code will cause crash in some cases.

Comment thread src/cefpython.pyx Outdated
with nogil:
CefDoMessageLoopWork()
time.sleep(0.01)
if not g_applicationSettings["multi_threaded_message_loop"]:

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

"multi_threaded_message_loop" key may not always exist in g_applicationSettings. You should use the GetAppSetting() function instead. Same for the other case later in code.

cztomczak left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This code will cause issues on Linux/Mac. See inline comment.

Comment thread src/cefpython.pyx
with nogil:
CefDoMessageLoopWork()
time.sleep(0.01)
if not GetAppSetting("multi_threaded_message_loop"):

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Multi threaded message loop is a Windows-only feature, so on other systems when this setting is set to True it should be ignored. CefDoMessageLoopWork should still be called on Linux/Mac. You should introduce a local variable multi_threaded_message_loop_windows and use it instead.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL