| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
…message_loop=True
There was a problem hiding this comment.
Thew new code will cause crash in some cases.
Sorry, something went wrong.
| with nogil: | ||
| CefDoMessageLoopWork() | ||
| time.sleep(0.01) | ||
| if not g_applicationSettings["multi_threaded_message_loop"]: |
There was a problem hiding this comment.
"multi_threaded_message_loop" key may not always exist in g_applicationSettings. You should use the GetAppSetting() function instead. Same for the other case later in code.
Sorry, something went wrong.
There was a problem hiding this comment.
This code will cause issues on Linux/Mac. See inline comment.
Sorry, something went wrong.
| with nogil: | ||
| CefDoMessageLoopWork() | ||
| time.sleep(0.01) | ||
| if not GetAppSetting("multi_threaded_message_loop"): |
There was a problem hiding this comment.
Multi threaded message loop is a Windows-only feature, so on other systems when this setting is set to True it should be ignored. CefDoMessageLoopWork should still be called on Linux/Mac. You should introduce a local variable multi_threaded_message_loop_windows and use it instead.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
No description provided.