Expose root_cache_path setting and set it in unit tests - #692
Open
linesight wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…zak#685) CEF 121+ logs a warning when CefSettings.root_cache_path is unset: 'Please customize CefSettings.root_cache_path for your application. Use of the default value may lead to unintended process singleton behavior.' This appeared when running the unit tests. cefpython never exposed root_cache_path, so it could not be set (SetApplicationSettings raised 'Invalid appSettings key'). Add it: - cef_types.pxd: declare root_cache_path in the CefSettings struct. - settings.pyx: handle the root_cache_path application setting. - unittests: set root_cache_path to a fixed dir under the system temp (_common.ROOT_CACHE_PATH) in main_test and osr_test, silencing the warning during the test run. - api/ApplicationSettings.md: document the new setting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #685
CEF 121+ logs a warning when CefSettings.root_cache_path is unset: 'Please customize CefSettings.root_cache_path for your application. Use of the default value may lead to unintended process singleton behavior.' This appeared when running the unit tests.
cefpython never exposed root_cache_path, so it could not be set (SetApplicationSettings raised 'Invalid appSettings key'). Add it: