FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(core): honor dependency pins over source refs by mglazer · Pull Request #13924 · dagger/dagger · GitHub

/ dagger Public

fix(core): honor dependency pins over source refs - #13924

Open
mglazer wants to merge 3 commits into
dagger:mainfrom
mglazer:mglazer/dependency-pin-precedence
Open

fix(core): honor dependency pins over source refs#13924
mglazer wants to merge 3 commits into
dagger:mainfrom
mglazer:mglazer/dependency-pin-precedence

Conversation

mglazer commented Aug 19, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Honor a dependency pin when source also contains a symbolic or versioned Git ref.
  • Skip source semver tag matching when a config pin is present.
  • Add a focused unit regression asserting that source @main plus pin v1.2.3 selects ref(name: "v1.2.3").
  • Keep integration coverage for the pinned remote dependency path.

Testing

Added additional unit tests.

AI Usage Disclaimer

I used AI for most of this change, aside from the PR description. It wrote code that is roughly on par with what I would have written myself and helped track down the precise issue far faster than I would have on my own.

Prefer the configured dependency pin when the source also contains a symbolic or versioned ref. Extend the named-pin regression fixture to cover a source ending in @main.

Signed-off-by: Mike Glazer <mike.glazer@gmail.com>
Signed-off-by: Mike Glazer <mike.glazer@gmail.com>
Signed-off-by: Mike Glazer <mike.glazer@gmail.com>
mglazer force-pushed the mglazer/dependency-pin-precedence branch from 5ada082 to 8131c0e Compare August 19, 2026 01:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL