fix module wiring with required Workspace args - #13933
Open
kpenfound wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: #13850 made declared Workspace! args truly required. dagql rejects a missing non-null arg before the injection hook that used to fill it, so any engine code that builds a module call by hand must now supply the
workspace itself. resolveModuleRef (core/schema/address.go), which resolves settings.x = ":" wiring, still selected the referenced module's constructor and function with no args — so wiring to any
module whose constructor (or referenced function) takes a Workspace failed with missing required argument: "ws".
Fix: resolveModuleRef now fills required Workspace args on both selectors via the same helper #13850 added for the other hand-built selectors (core.WithBoundWorkspaceArgs, exported), resolving the bound workspace in
context, else currentWorkspace.
Test: new workspace-container-provider fixture (required ws on constructor and on a function) + TestUpModuleWiring/provider_with_required_Workspace_arg; fails without the fix, passes with it. Existing wiring fixtures
had no Workspace args, which is why this wasn't caught.