FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add components overview by Granjow · Pull Request #810 · danielgerlag/workflow-core · GitHub

Add components overview - #810

Closed
Granjow wants to merge 4 commits into
danielgerlag:masterfrom
Granjow:feature/arch-docs
Closed

Add components overview#810
Granjow wants to merge 4 commits into
danielgerlag:masterfrom
Granjow:feature/arch-docs

Conversation

Granjow commented Apr 14, 2021

Copy link
Copy Markdown
Contributor

This documentation PR adds a short overview over some main components which are available in Workflow Core. Having a bigger picture or architecture view was something I missed when starting with Workflow Core.

I'd prefer something like a C4 components diagram, but readthedocs seems to be limited with diagram options.

Any suggestions/ideas?

danielgerlag left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is the target audience consumers of workflow core or contributors to the library itself?

Comment thread docs/getting-started.md Outdated

## Persistence

The persistence provider persists the state of a workflow instance with execution pointers. They are created when visiting a step while executing a workflow and hold information about their outcome.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think execution pointers are more of an internal concept, not really specific to persistence?
Either way, I'm not sure this paragraph gives a description of what they are.

Comment thread docs/getting-started.md Outdated

## Registry

The workflow host keeps workflow definitions in the registry when they are registered. When starting a workflow, the workflow host creates a new instance for the desired workflow definition.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The workflow host does not keep the definitions, the registry does, the workflow host accesses the registry.

Granjow commented Jun 9, 2021

Copy link
Copy Markdown
Contributor Author

@danielgerlag Thanks for your review, I have updated the pull request. Better now?

Target audience is mainly consumers of the library, but I have found it easier to work with Workflow Core when also understanding some of the more internal concepts.

Copy link
Copy Markdown
Collaborator

Closing as abandoned (draft, no updates since 2021). Please reopen or open a new PR if you still want this.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL