Fix: to_dict returns wrong enum fields when numbering is not consecutive - #102
Merged
boukeversteegh merged 3 commits intoJul 12, 2020
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…ng is not consecutive
boukeversteegh
force-pushed
the
fix/93_skipped_enum_values
branch
from
dee034f to
a945246
Compare
July 11, 2020 19:02
This was referenced Jul 12, 2020
boukeversteegh
commented
Jul 12, 2020
Comment thread
src/betterproto/__init__.py
Outdated
Comment on lines
+846
to
+855
| if field_is_repeated: | ||
| enum_class = field_type.__args__[0] | ||
| if isinstance(value, typing.Iterable): | ||
| output[cased_name] = [ | ||
| enum_class(element).name for element in value | ||
| ] | ||
| else: | ||
| warnings.warn( | ||
| f"Non-iterable value for repeated enum field {field_name}" | ||
| ) |
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
The actual fix is here ☝️
Sorry, something went wrong.
nat-n
approved these changes
Jul 12, 2020
Gobot1234
pushed a commit
to Gobot1234/python-betterproto
that referenced
this pull request
Aug 24, 2020
…ive (danielgtaylor#102) Fixes danielgtaylor#93 to_dict returns wrong enum fields when numbering is not consecutive
Merged
Copy link
Copy Markdown
|
Thanks for this bug fix! I just ran into this myself and it took me a while to realize the fix was available in version 2. Any when this will come out of beta? |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
No but if you want this fix install betterproto==2.0.0b2 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #93