Proto3 field presence - #268
Closed
roblabla wants to merge 8 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
roblabla
force-pushed
the
proto3-field-presence
branch
2 times, most recently
from
24c4851 to
7252a17
Compare
September 21, 2021 12:18
roblabla
force-pushed
the
proto3-field-presence
branch
from
7252a17 to
9a39e19
Compare
September 30, 2021 14:35
kalzoo
reviewed
Oct 15, 2021
Comment thread
src/betterproto/plugin/models.py
Comment thread
src/betterproto/lib/google/protobuf/__init__.py
Copy link
Copy Markdown
Collaborator
|
@nat-n, @boukeversteegh , or @danielgtaylor - mind having a look, or at least approving the GHA workflow? |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@roblabla could you fix up the code style? After that we should be all set here. |
Sorry, something went wrong.
This was referenced Nov 16, 2021
Merged
Closed
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #229
Fixes #35
Adds proto3 field presence support. Most of the infrastructure was already present to support it, all I had to do was add some plumbing:
The rest is mostly updating the documentation to take into account the field presence.