Move Docker install to Docker repo - #507
Merged
3alpha merged 7 commits intoNov 9, 2022
Merged
Conversation
3alpha
requested review from
dapplion,
eduadiez,
pablomendezroyo and
tropicar
as code owners
October 29, 2022 12:05
3alpha
force-pushed
the
3alpha/move-docker-to-repo-install
branch
from
740daf8 to
4241adc
Compare
October 29, 2022 12:16
3alpha
force-pushed
the
3alpha/move-docker-to-repo-install
branch
from
d40b05a to
cecea41
Compare
October 29, 2022 12:30
added 2 commits
October 29, 2022 14:57
Copy link
Copy Markdown
Member
Author
|
Sorry, something went wrong.
pablomendezroyo
approved these changes
Nov 7, 2022
Comment thread
scripts/dappnode_install_pre.sh
| CONTAINERD_URL="${DOCKER_REPO}/${CONTAINERD_PKG}" | ||
| DCMP_URL="https://github.com/docker/compose/releases/download/v2.5.0/docker-compose-linux-x86_64" | ||
| WGET="wget -q --show-progress --progress=bar:force" | ||
| lsb_dist="$(. /etc/os-release && echo "$ID")" |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
What if this commands returns a non-expected value, like someone is trying to install dappnode on a non-debian based machine. There should be kind of a check for the value output. But maybe its for a different issue
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
You're right, we should definitely check for that somewhere! Probably right place for that is at the very beginning.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I have tested the branch and it worked fine for me |
Sorry, something went wrong.
dsimog01
approved these changes
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.