Disable NVMe APST/power-save mode for ISO installs by adding nvme_core.default_ps_max_latency_us=0 to installer boot entries and to the installed system GRUB defaults generated by Debian preseed and Ubuntu autoinstall.
This targets intermittent crashes seen on some NVMe systems, including ASUS NUC 15 Pro hardware, where disabling NVMe power saving avoids periodic lockups.
Fixes #
Type of change
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
ISO install
Script install
Other (please detail)
Validated locally:
git diff --check
bash -n scripts/dappnode_install_pre.sh
Parsed both Ubuntu autoinstall YAML files with Ruby YAML loader
Test Configuration:
DAppNode version:
Hardware:
Toolchain:
SDK:
Checklist
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
I have checked my code and corrected any misspellings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disable NVMe APST/power-save mode for ISO installs by adding nvme_core.default_ps_max_latency_us=0 to installer boot entries and to the installed system GRUB defaults generated by Debian preseed and Ubuntu autoinstall.
This targets intermittent crashes seen on some NVMe systems, including ASUS NUC 15 Pro hardware, where disabling NVMe power saving avoids periodic lockups.
Fixes #
Type of change
How Has This Been Tested?
Validated locally:
Test Configuration:
Checklist