| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
DAppNode bot has built and pinned the release to an IPFS node, for commit: cab8455 This is a development version and should only be installed for testing purposes, install link /ipfs/QmP54nug2Lts5YvurF51YFsG1sdDgvgATRxcmbgHkZDPoL (by dappnodebot/build-action) |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Even thought this PR initially aimed with the objective of replacing the "Apm" class inside "src/utils/Apm.ts" file for dappnode's toolkit, as I was replacing it, I realised that this class was only used for resolving ENS names to addresses via it's ethereum Provider parameter, nothing specific to the Aragon Packet Manager.
The only Aragorn Packet Manager related methods are "encodeNewRepoWithVersionCall()" and "encodeNewVersionCall()" (which are not part of the Apm class itself, but are inside the same file).
So, in the end, this PR does the following:
Since CI is down atm, I ran all tests locally and passed.
TODO: We should consider adding "encodeNewRepoWithVersionCall()" and "encodeNewVersionCall()" to the dappnode toolkit, and then updating the SDK code again. Also, we should rename "src/utils/Apm.ts" file name, but kept it the same so reviewing this PR is easier