Avoid installing a global uncaughtException handler on import - #112
Open
PNHD wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
daquinoaldo
approved these changes
Aug 22, 2026
daquinoaldo
left a comment
Copy link
Copy Markdown
Owner
There was a problem hiding this comment.
Hi @PNHD!
Thanks for the PR. The code looks good. I’m on holidays, I’ll release in a week once I’m back.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Related Issue
Addresses #77.
Importing https-localhost currently installs a process-wide uncaughtException handler even when the package is only used as a module. That changes application-level error handling and can hide the original stack-trace behavior.
This change scopes the existing handler to the CLI path (require.main === module) so the CLI keeps its friendly EACCES / EADDRINUSE messages while library consumers no longer get a global process listener as a side effect of require("https-localhost").
A regression test re-imports the module after clearing the require cache and verifies that the uncaughtException listener count does not change.
Types of changes
Checklist