valkey test container - #1
Open
daric93 wants to merge 9 commits into
Open
Conversation
Copy link
Copy Markdown
Owner
Sorry, something went wrong.
jbrinkman
reviewed
Dec 11, 2025
Comment thread
modules/valkey/testcontainers/valkey/__init__.py
Outdated
Comment thread
modules/valkey/testcontainers/valkey/__init__.py
Outdated
| """ | ||
| return int(super().get_exposed_port(self.port)) | ||
|
|
||
| @wait_container_is_ready(ValkeyNotReady) |
Copy link
Copy Markdown
There was a problem hiding this comment.
Deprecated Decorator Usage
Location: modules/valkey/testcontainers/valkey/__init__.py, line 113
Current Code:
@wait_container_is_ready(ValkeyNotReady)
def _connect(self) -> None:
"""Wait for Valkey to be ready by sending PING command."""
# ... connection logicIssue:
The @wait_container_is_ready decorator is deprecated in the codebase. Recent commits show active migration away from this pattern:
- PR feat: Add ExecWaitStrategy and migrate Postgres from deprecated decorator testcontainers/testcontainers-python#935: Postgres migrated to ExecWaitStrategy
- PR fix(minio): Use wait strategy instead of deprecated decorator testcontainers/testcontainers-python#899: Minio migrated to wait strategies
- PR fix(elasticsearch): Use wait strategy instead of deprecated decorator testcontainers/testcontainers-python#915: Elasticsearch migrated to wait strategies
Evidence from Codebase:
# From pytest.ini_options filterwarnings:
"ignore:The @wait_container_is_ready decorator is deprecated.*:DeprecationWarning"Recommended Fix:
Migrate to modern wait strategy pattern:
from testcontainers.core.wait_strategies import ExecWaitStrategy
class ValkeyContainer(DockerContainer):
def __init__(self, image: str = "valkey/valkey:latest", port: int = 6379, **kwargs) -> None:
super().__init__(image, **kwargs)
self.port = port
self.password: Optional[str] = None
self.with_exposed_ports(self.port)
def start(self) -> "ValkeyContainer":
# Build wait strategy based on password
if self.password:
# Use custom wait strategy for authenticated connections
self.waiting_for(self._create_auth_wait_strategy())
else:
# Use exec strategy for simple PING
self.waiting_for(
ExecWaitStrategy(["valkey-cli", "ping"])
)
super().start()
return selfBenefits:
- Aligns with project direction
- More composable and testable
- Consistent with other modules
- Better error messages
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
Author
There was a problem hiding this comment.
fixed
Sorry, something went wrong.
Comment thread
modules/valkey/example_basic.py
Outdated
Signed-off-by: Daria Korenieva <daric2612@gmail.com>
daric93
force-pushed
the
valkey_test_container
branch
from
4c8007b to
21ec9f8
Compare
April 7, 2026 19:52
Signed-off-by: Daria Korenieva <daric2612@gmail.com>
🤖 I have created a release *beep* *boop* --- ## [4.15.0-rc.1](testcontainers/testcontainers-python@testcontainers-v4.14.2...testcontainers-v4.15.0-rc.1) (2026-04-07) ### Features * **compose:** add structured container inspect information ([testcontainers#897](testcontainers#897)) ([58459a1](testcontainers@58459a1)) * **core:** support SSH-based DOCKER_HOST ([testcontainers#993](testcontainers#993)) ([d48115d](testcontainers@d48115d)) * **generic:** Reintroducing the generic SQL module ([testcontainers#892](testcontainers#892)) ([2ca2321](testcontainers@2ca2321)) * **keycloak:** support for relative path and management relative path ([testcontainers#982](testcontainers#982)) ([898faf6](testcontainers@898faf6)) * **mqtt:** MosquittoContainer: Add version 2.1.2 ([testcontainers#978](testcontainers#978)) ([af382f7](testcontainers@af382f7)) ### Bug Fixes * **azurite:** make visible to type checkers ([testcontainers#927](testcontainers#927)) ([baa5668](testcontainers@baa5668)) * **clickhouse:** add `HttpWaitStrategy` instead of deprecated `wait_container_is_ready` ([testcontainers#962](testcontainers#962)) ([8034541](testcontainers@8034541)) * **compose:** return type in get_service_port docstring ([testcontainers#939](testcontainers#939)) ([fed65fe](testcontainers@fed65fe)) * **core:** Refactor copy file ([testcontainers#996](testcontainers#996)) ([0e0bb24](testcontainers@0e0bb24)) * **core:** wait for ryuk more reliably, improve tests: long_running, filter logs ([testcontainers#984](testcontainers#984)) ([b12ae13](testcontainers@b12ae13)) * **generic:** Migrate ServerContainer from deprecated decorator to HttpWaitStrategy ([testcontainers#971](testcontainers#971)) ([460b0d8](testcontainers@460b0d8)) * **kafka:** Use wait strategy instead of deprecated wait_for_logs ([testcontainers#903](testcontainers#903)) ([87332c1](testcontainers@87332c1)) * **postgres:** add py.typed marker to postgres module ([testcontainers#849](testcontainers#849)) ([c8a5bbd](testcontainers@c8a5bbd)) * **qdrant:** migrate Qdrant from deprecated decorator. ([testcontainers#963](testcontainers#963)) ([407f798](testcontainers@407f798)) * **redis:** Use wait strategy instead of deprecated decorator ([testcontainers#914](testcontainers#914)) ([e25713a](testcontainers@e25713a)) * **sftp:** Avoid using wait_for_logs in module. ([testcontainers#995](testcontainers#995)) ([83157eb](testcontainers@83157eb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: David Ankin <daveankin@gmail.com>
Signed-off-by: Daria Korenieva <daric2612@gmail.com>
…ners-python into valkey_test_container
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.