FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[imageio] Avoid reading TIFF files made from raw as raw format by victoryforce · Pull Request #19189 · darktable-org/darktable · GitHub

[imageio] Avoid reading TIFF files made from raw as raw format - #19189

Merged
TurboGit merged 1 commit into
darktable-org:masterfrom
victoryforce:fix-19131
Oct 3, 2025
Merged

TurboGit merged 1 commit into
darktable-org:masterfrom
victoryforce:fix-19131

Conversation

Copy link
Copy Markdown
Collaborator

If some program creates a TIFF file from a raw file which is based on a TIFF container, while preserving all Exif data, such a file cannot be distinguished from a raw file by its signature.

We want to support reading such TIFFs, and even those that, by mistake, contain metadata specific to raw files. The raw loader may in this case conclude that it is reading a raw file and produce wrong image. We can fix this by calling TIFF loader first. It checks the file extension and limits itself to processing only .tif/.tiff. So it's safe for nearly all raw files except those few disguised as TIFF files (actually they are a hybrid TIFF+Raw) with .tif extension. Obviously, for these tricky files, this function should not be called.

Resolves #19131.

TurboGit added this to the 5.4 milestone Aug 22, 2025
TurboGit added bugfix pull request fixing a bug priority: medium core features are degraded in a way that is still mostly usable, software stutters feature: redesign current features to rewrite release notes: pending labels Aug 22, 2025

TurboGit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

TurboGit merged commit b6f6f8a into darktable-org:master Oct 3, 2025
6 checks passed
victoryforce deleted the fix-19131 branch October 3, 2025 16:34

TurboGit commented Oct 9, 2025

Copy link
Copy Markdown
Member

@victoryforce : Can you propose a release note entry for this? TIA.

Copy link
Copy Markdown
Collaborator Author

@victoryforce : Can you propose a release note entry for this? TIA.

I'll think about the wording. So far I can't explain what exactly has been fixed in less than a few paragraphs. I need to briefly describe two problems, two types of not very correctly made files that we need to read both correctly:

  • raw files with the .tif extension, which unfortunately also contain a tiff file, but we need to read from these files the raw data that is also there.

  • tiff files to which metadata of the source (from which they are made) raw files has been added, which allows the raw file loader to successfully read them as raw and output garbage data.

Copy link
Copy Markdown
Member

@victoryforce : A gentle ping :)

Copy link
Copy Markdown
Collaborator Author

Well, I suggest just writing in the release notes:

Fixed an issue with reading TIFF files that (incorrectly) contain metadata specific to the raw files they were made from.

There's probably no need to go into technical details of what happened, why it happened and how it was fixed...

Copy link
Copy Markdown
Member

Thanks!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug feature: redesign current features to rewrite priority: medium core features are degraded in a way that is still mostly usable, software stutters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

processing TIFF32 (exported from RAW) causes error

2 participants


Back | FazBrowse Home | New Git URL