| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
I am not typing expert but I think we need TypeVar(T, bound='array') now (PEP 484), and in the future Self (PEP 673). The current approach would not work for subclasses. My vote would go for the status quo (no type hint for self) but let's wait for others to chime in. |
Sorry, something went wrong.
|
array is what the other methods use so keeping that here is fine. We can open another issue about using a different type hint for self. |
Sorry, something went wrong.
|
CI failure is unrelated, let's retry that. |
Sorry, something went wrong.
|
Sorry, so this PR does two things:
Let's do that. |
Sorry, something went wrong.
|
Okay, CI is unrelated, I'll open a separate issue for that too. |
Sorry, something went wrong.
|
Yeah the CI failure is likely a permission issue that we also hit before. |
Sorry, something went wrong.
|
The type hint for self is one instance of a general pattern; same as for scalars we use int and not anything that ducktypes with int (which can be type-able by SupportsInt or some such thing). |
Sorry, something went wrong.
There was a problem hiding this comment.
So it looks like we're happy here, in it goes.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
No description provided.