| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
This change seems reasonable to me, it's more of a clarification than anything else. This numbered list was written with creation functions in mind I believe. The device= keyword descriptions already say something like "if device is None, use the device from the input array" in the relevant cases. Before merging this, let's ensure the discussions in data-apis/array-api-compat#293 (and perhaps other places) have been settled to ensure it's all consistent. |
Sorry, something went wrong.
Sorry, something went wrong.
Co-authored-by: Lucy Liu <jliu176@gmail.com>
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
Based on linked discussions and workgroup discussion, the proposed rule changes have agreement. As such, I'll go ahead and merge. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Clarify how input arrays should be considered for device placement.
This new line is a repetition of bullet point 2, three lines above:
However, I am observing very high levels of ambiguity among the community on the interpretation of this paragraph, where I've had multiple people insist that the device set in the context manager or global default device should trump the device of input arrays. At which point, since all real-life backends always have a global default device, input-to-output device propagation would fly out of the window.