MAINT: validate device on numpy and dask - #301
Merged
ev-br merged 1 commit intoApr 8, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds device validation for NumPy and Dask functions by replacing manual device checks with a shared helper function.
- Introduces _helpers._check_device calls in both NumPy and Dask array functions.
- Updates helper function _check_device to support device validation for both array backends.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| array_api_compat/numpy/_aliases.py | Replaces manual device validation with _helpers._check_device call. |
| array_api_compat/dask/array/_aliases.py | Adds _helpers._check_device call in multiple functions. |
| array_api_compat/common/_helpers.py | Refactors _check_device to support both NumPy and Dask device checks. |
Sorry, something went wrong.
Comment thread
array_api_compat/common/_helpers.py
Outdated
crusaderky
force-pushed
the
check_device
branch
2 times, most recently
from
030d62d to
e718c7b
Compare
April 3, 2025 11:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvaged from #293.