ENH: torch: allow complex arguments to var and std - #445
Open
ev-br wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
While at it, float `correction` seems to be supported, at least with torch 2.10?
5 tasks
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the PyTorch Array API compatibility aliases to better align std()/var() behavior with complex inputs and (intended) floating-point correction handling.
Changes:
- Adjust std() to pass through correction without forcing integer conversion.
- Ensure std()/var() return a real-valued zeros output for the special-case axis == () path when inputs are complex.
- Introduce a complex→real dtype mapping used for that axis == () behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
src/array_api_compat/torch/_aliases.py
Comment on lines
436
to
+446
| # Note, float correction is not supported | ||
| # https://github.com/pytorch/pytorch/issues/61492. We don't try to | ||
| # implement it here for now. | ||
|
|
||
| if isinstance(correction, float): | ||
| _correction = int(correction) | ||
| if correction != _correction: | ||
| raise NotImplementedError("float correction in torch std() is not yet supported") | ||
| else: | ||
| _correction = correction | ||
| #if isinstance(correction, float): | ||
| # _correction = int(correction) | ||
| # if correction != _correction: | ||
| # raise NotImplementedError("float correction in torch std() is not yet supported") | ||
| #else: | ||
| # _correction = correction | ||
| _correction = correction |
Comment thread
src/array_api_compat/torch/_aliases.py
Comment thread
src/array_api_compat/torch/_aliases.py
Comment thread
src/array_api_compat/torch/_aliases.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While at it, float correction seems to be supported, at least with torch 2.10?
cross-ref data-apis/array-api#1007, data-apis/array-api-tests#437