TST: Test copy behavior in astype - #335
Draft
lithomas1 wants to merge 1 commit into
Draft
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
crusaderky
suggested changes
Jan 16, 2025
Comment thread
array_api_tests/pytest_helpers.py
| """ | ||
| Assert copy=True/False functionality is respected | ||
|
|
||
| TODO: we're not able to check scalars with this approach |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
We should definitely be able to check 0-dimensional arrays. What we can't check is np.generic, which AFAIK is a numpy-specific type
Sorry, something went wrong.
Comment thread
array_api_tests/pytest_helpers.py
Comment on lines
+497
to
+501
| def assert_kw_copy(func_name, x, out, data, copy): | ||
| """ | ||
| Assert copy=True/False functionality is respected | ||
|
|
||
| TODO: we're not able to check scalars with this approach |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This doesn't look right.
- astype(copy=True) should behave like asarray(copy=True).
- astype(copy=False) should behave like asarray(copy=None).
- asarray(copy=False) has no matching behaviour in astype.
Sorry, something went wrong.
Copy link
Copy Markdown
Author
Planning on circling back since the dask PR is merged now. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The copy keyword was previously not checked.