CloudSql PostegreSql e2e test scenarios - #200
Conversation
Sorry, something went wrong.
cloudSqlPSQL related test scenarios
rmstar
left a comment
There was a problem hiding this comment.
We should have separate tests for source and sink plugins
Sorry, something went wrong.
| @@ -0,0 +1,103 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- | |||
| Copyright © 2015-2019 Cask Data, Inc. | |||
There was a problem hiding this comment.
2022
Sorry, something went wrong.
| @@ -0,0 +1,45 @@ | |||
| Feature: CloudSQLPostgreSQL Sink and Error Validation | |||
There was a problem hiding this comment.
Capitalize first letter in filename - cloudSql -> CloudSql
Sorry, something went wrong.
| @Then("Enter the CloudSQLPostgreSQL Source Properties with blank property {string}") | ||
| public void enterTheCloudSQLPostgreSQLSourcePropertiesWithBlankProperty(String property) throws IOException, | ||
| InterruptedException { | ||
| if (property.equalsIgnoreCase("referenceName")) { |
There was a problem hiding this comment.
avoid code duplication
Sorry, something went wrong.
| } | ||
|
|
||
| @Then("Verify error is displayed for incorrect Connection Name with private instance type") | ||
| public void verifyTheCldMySqlInvalidPrivate() throws InterruptedException { |
There was a problem hiding this comment.
fix name
Sorry, something went wrong.
| @Then("Enter the CloudSQLPostgreSQL Sink Properties with blank property {string}") | ||
| public void enterTheCloudSQLPostgreSQLSinkPropertiesWithBlankProperty(String property) throws IOException, | ||
| InterruptedException { | ||
| if (property.equalsIgnoreCase("referenceName")) { |
There was a problem hiding this comment.
avoid code duplication
Sorry, something went wrong.
| } | ||
|
|
||
| @Then("Enter Connection Name with private instance type") | ||
| public void enterTheInvalidPrivate() throws InterruptedException, IOException { |
There was a problem hiding this comment.
where is this used? also, please rename to something more meaningful
Sorry, something went wrong.
Reviewers
At least 1 approving review is required to merge this pull request.
@tivv @rmstar @itsankit-google Please review.