[PECO-930] Add parameterized query support. - #162
Merged
nithinkdb merged 11 commits intoSep 6, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
nithinkdb
requested review from
andrefurlan-db,
arikfr,
kravets-levko,
superdupershant,
susodapop and
yunbodeng-db
as code owners
August 17, 2023 23:55
Comment thread
lib/DBSQLClient.ts
Comment thread
lib/utils/ParameterConverter.ts
Outdated
Comment thread
lib/contracts/IDBSQLSession.ts
Outdated
Comment thread
lib/contracts/IDBSQLSession.ts
Outdated
Comment thread
lib/connection/connections/HttpConnection.ts
Outdated
Comment thread
tests/e2e/parameterized_query.test.js
Outdated
Comment thread
tests/e2e/parameterized_query.test.js
Outdated
andrefurlan-db
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
please make sure that we keep it consistent with Go and Python. @rcypher-databricks needs to review this as well
Sorry, something went wrong.
rcypher-databricks
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
As we discussed I think we need to provide a mechanism where the user can specify the desired sql type.
Sorry, something went wrong.
Comment thread
lib/utils/convertToSparkParameters.ts
Outdated
rcypher-databricks
approved these changes
Sep 1, 2023
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levko
force-pushed
the
PECO-930
branch
from
baffb1f to
6b28a0d
Compare
September 5, 2023 18:22
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levko
approved these changes
Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #96