FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(kernel): preserve qualified interval parameter types by cathleeny · Pull Request #514 · databricks/databricks-sql-nodejs · GitHub

fix(kernel): preserve qualified interval parameter types - #514

Draft
cathleeny wants to merge 1 commit into
mainfrom
PECOBLR-4169
Draft

fix(kernel): preserve qualified interval parameter types#514
cathleeny wants to merge 1 commit into
mainfrom
PECOBLR-4169

Conversation

cathleeny commented Aug 26, 2026
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve qualified interval parameter types such as INTERVAL MONTH and INTERVAL DAY in the kernel backend.
  • Send parameters through the kernel's raw-parameter path, matching the Go driver.
  • Add unit and end-to-end coverage for interval binding.

Merge order

  1. Merge databricks-sql-kernel#298.
  2. Update this branch to pin the merged kernel revision, then merge this PR.
  3. Merge databricks-driver-test#1419, which re-enables the interval cases.

This draft intentionally leaves KERNEL_REV unchanged until the kernel PR merges.

Testing

  • npm test -- tests/unit/kernel/positionalParams.test.ts tests/unit/kernel/execution.test.ts (83 passing)
  • npx tsc --noEmit --project tsconfig.build.json
  • npm run lint
  • Prettier check on changed files
  • Local Node → rebuilt kernel N-API → mock SEA run emitted {"ordinal":1,"type":"INTERVAL MONTH","value":"2-6"}

PECOBLR-4169

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: Cathleen Yan <cathleen.yan@databricks.com>

Copy link
Copy Markdown
Collaborator Author

TODO: Pin latest kernel ref when the kernel rawParam PR is merged

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL