FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Relax panda and alembic requirements by bkyryliuk · Pull Request #116 · databricks/databricks-sql-python · GitHub

/ databricks-sql-python Public

Relax panda and alembic requirements - #116

Closed
bkyryliuk wants to merge 1 commit into
databricks:mainfrom
bkyryliuk:bogdan/relax_deps
ConversationCommits (1)ChecksFiles changed
Closed

Relax panda and alembic requirements#116
bkyryliuk wants to merge 1 commit into
databricks:mainfrom
bkyryliuk:bogdan/relax_deps

Conversation

bkyryliuk commented May 3, 2023

Copy link
Copy Markdown
Contributor

Pandas 1.3+ has a regression: pandas-dev/pandas#42549
This PR proposes relaxing alembic and panda requirements

susodapop commented May 3, 2023

Copy link
Copy Markdown
Contributor

Good idea.

I'm working on this exact change locally, actually. Just running our e2e tests before pushing my own branch. This PR won't quite work because you haven't included the DCO in your commit (see CONTRIBUTING.md for details).

bkyryliuk commented May 3, 2023

Copy link
Copy Markdown
Contributor Author

Good idea.

I'm working on this exact change locally, actually. Just running our e2e tests before pushing my own branch. This PR won't quite work because you haven't included the DCO in your commit (see CONTRIBUTING.md for details).

that's great. TY! Will check on DCO

bkyryliuk force-pushed the bogdan/relax_deps branch from 502855f to 4685d6f Compare May 3, 2023 16:33
Relax panda and alembic requirements
7c79cbe 
Signed-off-by: Bogdan Kyryliuk <b.kyryliuk@gmail.com>
bkyryliuk force-pushed the bogdan/relax_deps branch from 4685d6f to 7c79cbe Compare May 3, 2023 16:34
susodapop mentioned this pull request May 9, 2023
Merged

susodapop commented May 9, 2023

Copy link
Copy Markdown
Contributor

I've mirrored this change in #119 so I can verify it builds. This change will be part of v2.5.2 releasing shortly.

susodapop closed this May 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

arikfr Awaiting requested review from arikfr
yunbodeng-db Awaiting requested review from yunbodeng-db
andrefurlan-db Awaiting requested review from andrefurlan-db
1 more reviewer
susodapop susodapop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL