fix dco issue - #42
Merged
moderakh merged 2 commits intoAug 25, 2022
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Signed-off-by: Moe Derakhshani <moe.derakhshani@databricks.com>
Signed-off-by: Moe Derakhshani <moe.derakhshani@databricks.com>
moderakh
requested review from
arikfr,
susodapop and
yunbodeng-db
as code owners
August 25, 2022 19:04
Merged
moderakh
added a commit
that referenced
this pull request
Aug 25, 2022
Signed-off-by: Moe Derakhshani <moe.derakhshani@databricks.com> this is undo of #42 till we figure out how to fix dco
saishreeeee
pushed a commit
that referenced
this pull request
Jun 4, 2025
Signed-off-by: Moe Derakhshani <moe.derakhshani@databricks.com> my [OAuth PR](https://github.com/databricks/databricks-sql-python/runs/8005844758?check_suite_focus=true) is blocked due to dco validation (following error): <img width="1202" alt="Screen Shot 2022-08-25 at 12 05 40 PM" src="https://user-images.githubusercontent.com/22279672/186747897-c9d57586-366f-41f9-aa66-609f2bf3911f.png"> We should try to avoid running dco for internal databricks employees: I am trying to relax the validation based on this guideline: https://github.com/dcoapp/app/blob/main/README.md#skipping-sign-off-for-organization-members and here: https://stackoverflow.com/questions/62969381/is-it-in-line-with-the-dco-that-a-github-sign-off-needs-and-publishes-full-name
saishreeeee
pushed a commit
that referenced
this pull request
Jun 4, 2025
Signed-off-by: Moe Derakhshani <moe.derakhshani@databricks.com> this is undo of #42 till we figure out how to fix dco
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Moe Derakhshani moe.derakhshani@databricks.com
my OAuth PR is blocked due to dco validation (following error):
We should try to avoid running dco for internal databricks employees:
I am trying to relax the validation based on this guideline:
https://github.com/dcoapp/app/blob/main/README.md#skipping-sign-off-for-organization-members
and here:
https://stackoverflow.com/questions/62969381/is-it-in-line-with-the-dco-that-a-github-sign-off-needs-and-publishes-full-name